Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Зубакин Ренат #196

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

SolarHunger
Copy link

Comment on lines 28 to 31
private readonly Dictionary<MemberInfo, Delegate> customPropertySerialize =
new Dictionary<MemberInfo, Delegate>();

private readonly Dictionary<Type, Delegate> customTypeSerializers = new Dictionary<Type, Delegate>();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут же явно можно положить какая функция тут лежит

Comment on lines 32 to 33
private HashSet<object> visitedObjects = new HashSet<object>();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Этим множеством ты убиваешь одновременный запуск сериализаторого твоего

Comment on lines 57 to 58
if (obj is IDictionary)
{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obj is IDictionary dictionary

public string PrintToString(TOwner obj)
{
return PrintToString(obj, 0);
}

private string PrintToString(object obj, int nestingLevel)
{
var builder = new StringBuilder();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кадется лишнее поле

Comment on lines 141 to 143
private bool IsExclude(MemberInfo member)
{
return excludedTypes.Contains(member.GetType()) || excludedProperty.Contains(member);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Получай PropertyInfo и member.PropertyType сработает все

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants